Skip to content

Fix: default has_vulnerability_alerts to false#71

Merged
bzarboni1 merged 4 commits into
mainfrom
copilot/fix-vulnerability-alerts-default
Apr 28, 2026
Merged

Fix: default has_vulnerability_alerts to false#71
bzarboni1 merged 4 commits into
mainfrom
copilot/fix-vulnerability-alerts-default

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 28, 2026 •
edited
Loading

  • Change has_vulnerability_alerts default from true to false in modules/repository_base/variables.tf
  • Add has_vulnerability_alerts variable (default false) to public/private/internal repository modules
  • Wire var.has_vulnerability_alerts through to repository_base in all three sub-modules
  • Pass has_vulnerability_alerts through in modules/repository_set/repositories.tf
  • Update READMEs for all affected modules
  • Add has_vulnerability_alerts = optional(bool, false) to public_repositories type in modules/repository_set/variables.tf (CI fix)
  • Add has_vulnerability_alerts = optional(bool, false) to internal_repositories type in modules/repository_set/variables.tf (CI fix)
  • Create .github/workflows/copilot-setup-steps.yml to pre-install Terraform for local validation

Copilot AI linked an issue Apr 28, 2026 that may be closed by this pull request
[BUG] - Vulnerability Alerts should be off, unless configured #70
Closed
Copilot AI changed the title [WIP] Fix default setting for vulnerability alerts Fix: default has_vulnerability_alerts to false Apr 28, 2026
Copilot AI requested a review from bzarboni1 April 28, 2026 13:04
@bzarboni1 bzarboni1 marked this pull request as ready for review April 28, 2026 13:04
@seanpoulter-foci
Copy link
Copy Markdown
Contributor

seanpoulter-foci commented Apr 28, 2026

@copilot, the workflow failure should not happen. Please improve your own tooling and instructions to prevent this from happening. Use https://github.com/foci-github-foundations/organizations/blob/main/.github/workflows/copilot-setup-steps.yml for inspiration to ensure the required tools are available.

Copy link
Copy Markdown
Contributor Author

Copilot AI commented Apr 28, 2026

@copilot, the workflow failure should not happen. Please improve your own tooling and instructions to prevent this from happening. Use https://github.com/foci-github-foundations/organizations/blob/mai...

Fixed in feeb89f.

Two changes:

  1. CI failure root cause: has_vulnerability_alerts was missing from the public_repositories and internal_repositories object type definitions in repository_set/variables.tf, so each.value.has_vulnerability_alerts failed with "Unsupported attribute". Added has_vulnerability_alerts = optional(bool, false) to both.

  2. Tooling: Added .github/workflows/copilot-setup-steps.yml that pre-installs Terraform 1.9.8 (matching the version in the PR workflow), so future sessions can run terraform test locally to catch these errors before pushing.

@bzarboni1 bzarboni1 merged commit 7ebc560 into main Apr 28, 2026
2 checks passed
@bzarboni1 bzarboni1 deleted the copilot/fix-vulnerability-alerts-default branch April 28, 2026 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@seanpoulter-foci seanpoulter-foci seanpoulter-foci approved these changes

+1 more reviewer

@bzarboni1 bzarboni1 bzarboni1 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@bzarboni1 bzarboni1

Copilot code review Copilot

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[BUG] - Vulnerability Alerts should be off, unless configured

3 participants

@seanpoulter-foci @bzarboni1